mmsegmentation icon indicating copy to clipboard operation
mmsegmentation copied to clipboard

Keep train/valand eval configs separated

Open mawanda-jun opened this issue 3 years ago • 2 comments
trafficstars

When structuring the configuration, it's useful to keep the training, validation and evaluation configurations separated. In this case, it'd be useful to have a test configuration all alone, letting a separated validation configuration.

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

mawanda-jun avatar Jul 12 '22 15:07 mawanda-jun

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 12 '22 15:07 CLAassistant

Codecov Report

Merging #1760 (9bdf791) into master (8556944) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1760   +/-   ##
=======================================
  Coverage   89.04%   89.04%           
=======================================
  Files         144      144           
  Lines        8636     8636           
  Branches     1458     1458           
=======================================
  Hits         7690     7690           
  Misses        706      706           
  Partials      240      240           
Flag Coverage Δ
unittests 89.04% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/apis/train.py 19.51% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 891448f...9bdf791. Read the comment docs.

codecov[bot] avatar Jul 12 '22 17:07 codecov[bot]