mmpose icon indicating copy to clipboard operation
mmpose copied to clipboard

[codecamp: mmpose-529]Add the new config of the adaptive attitude estimation algorithm DARK

Open kingyaaa opened this issue 2 years ago • 2 comments

Motivation

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • [ ] I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • [ ] Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • [ ] Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • [ ] New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • [ ] The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • [ ] CLA has been signed and all committers have signed the CLA in this PR.

kingyaaa avatar Aug 21 '23 13:08 kingyaaa

在进行pre-commit检查时是全部passed的,但是进行pr提交的CI测试则会产生failed

kingyaaa avatar Aug 21 '23 13:08 kingyaaa

@kingyaaa 你好,第一次pre-commit会自动修正代码格式,这个时候需要再git add和commit一下,可以改动文件后再尝试一次。新的config请不要用new_config.py命名,请按照和旧版本 configs 文件路径下一样的目录结构和命名方式来组织。

PR 代码请提交到 dev-1.x分支,我已帮你切换,但是你fork的代码版本已落后与官方分支,请按照下面的指令更新一下你的本地分支:

# 切换到你 fork 的 dev-1.x
git checkout dev-1.x

# 拉取最新的 dev-1.x
git pull upstream dev-1.x

# 切换回你的 pr 分支
git checkout kingyaaa/mmpose-529

# rebase dev-1.x
git rebase dev-1.x

# push 更新你的 pr
git push origin  kingyaaa/mmpose-529 -f

Tau-J avatar Aug 22 '23 05:08 Tau-J