mmpose icon indicating copy to clipboard operation
mmpose copied to clipboard

[CodeCamp#158] SimCC 1d heatmap visualization

Open jack0rich opened this issue 2 years ago • 5 comments

Motivation

Visualize SimCC one-dimensional heatmap.

Modification

A new method named _draw_instance_xy_heap is extended in PoseLocalVisualizer to support the visualization of heatmaps such as SimCC.

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • [ ] I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • [ ] Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • [ ] Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • [ ] New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • [ ] The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • [ ] CLA has been signed and all committers have signed the CLA in this PR.

jack0rich avatar Jan 02 '23 11:01 jack0rich

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 02 '23 11:01 CLAassistant

Thank you very much for your contribution. This PR will be reviewed asap.

ly015 avatar Jan 03 '23 07:01 ly015

Hi @jack0rich , would you mind fixing the lint and adding an example of simcc visualization result to visualization docs?

Tau-J avatar Jan 12 '23 09:01 Tau-J

Hi @jack0rich , would you mind fixing the lint and adding an example of simcc visualization result to visualization docs?

Sure, but I'm confused about lint.Is there a problem with the copyright of simcc_vis.py? 93F2344E-E7F8-42FF-8352-E0BAFD69FBE5

jack0rich avatar Jan 12 '23 11:01 jack0rich

Sure, but I'm confused about lint.Is there a problem with the copyright of simcc_vis.py? 93F2344E-E7F8-42FF-8352-E0BAFD69FBE5

Hi @jack0rich, the copyright description

# Copyright (c) OpenMMLab. All rights reserved.

is needed at the top of new files

Ben-Louis avatar Jan 16 '23 07:01 Ben-Louis