mmpose icon indicating copy to clipboard operation
mmpose copied to clipboard

[Refactor] Support CID

Open Ben-Louis opened this issue 2 years ago • 1 comments

Motivation

Modification

  1. add CIDHead
  2. add a codec for CID named 'DecoupledHeatmap', which means that the heatmaps for each instance are decoupled and represented on different channels
  3. add configs

TODO:

  • [x] add unittests
  • [x] add docstrings

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • [ ] I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • [ ] Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • [ ] Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • [ ] New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • [ ] The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • [ ] CLA has been signed and all committers have signed the CLA in this PR.

Ben-Louis avatar Dec 30 '22 06:12 Ben-Louis

Codecov Report

Base: 80.17% // Head: 82.08% // Increases project coverage by +1.90% :tada:

Coverage data is based on head (96b5f8c) compared to base (d83c4ba). Patch coverage: 87.24% of modified lines in pull request are covered.

:exclamation: Current head 96b5f8c differs from pull request most recent head 70acbbe. Consider uploading reports for the commit 70acbbe to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #1907      +/-   ##
===========================================
+ Coverage    80.17%   82.08%   +1.90%     
===========================================
  Files          210      213       +3     
  Lines        12522    12650     +128     
  Branches      2112     2130      +18     
===========================================
+ Hits         10040    10384     +344     
+ Misses        2028     1803     -225     
- Partials       454      463       +9     
Flag Coverage Δ
unittests 82.08% <87.24%> (+1.90%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/visualization/local_visualizer.py 79.54% <55.55%> (-1.30%) :arrow_down:
mmpose/datasets/transforms/bottomup_transforms.py 79.77% <75.00%> (-0.11%) :arrow_down:
mmpose/models/heads/heatmap_heads/cid_head.py 80.45% <80.45%> (ø)
mmpose/models/utils/transformer.py 82.40% <87.50%> (+8.28%) :arrow_up:
mmpose/codecs/decoupled_heatmap.py 88.42% <88.42%> (ø)
mmpose/codecs/utils/instance_property.py 89.18% <89.18%> (ø)
mmpose/codecs/utils/gaussian_heatmap.py 86.02% <90.00%> (+0.46%) :arrow_up:
mmpose/visualization/simcc_vis.py 98.59% <98.59%> (ø)
mmpose/__init__.py 100.00% <100.00%> (ø)
mmpose/apis/inference.py 76.23% <100.00%> (+0.72%) :arrow_up:
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jan 16 '23 16:01 codecov[bot]