mmpose icon indicating copy to clipboard operation
mmpose copied to clipboard

tests folder should exclude from the installation

Open hubutui opened this issue 3 years ago • 2 comments

Thanks for your error report and we appreciate it a lot. If you feel we have helped you, give us a STAR! :satisfied:

Checklist

  1. I have searched related issues but cannot get the expected help.
  2. The bug has not been fixed in the latest version.

Describe the bug

tests folder should exclude from the installation, currently tests in installed at site-packages dir:

python-mmpose /usr/lib/python3.10/site-packages/tests/
python-mmpose /usr/lib/python3.10/site-packages/tests/__init__.py
python-mmpose /usr/lib/python3.10/site-packages/tests/__pycache__/
python-mmpose /usr/lib/python3.10/site-packages/tests/__pycache__/__init__.cpython-310.opt-1.pyc
python-mmpose /usr/lib/python3.10/site-packages/tests/__pycache__/__init__.cpython-310.pyc
python-mmpose /usr/lib/python3.10/site-packages/tests/__pycache__/test_config.cpython-310.opt-1.pyc
python-mmpose /usr/lib/python3.10/site-packages/tests/__pycache__/test_config.cpython-310.pyc
python-mmpose /usr/lib/python3.10/site-packages/tests/__pycache__/test_eval_hook.cpython-310.opt-1.pyc
python-mmpose /usr/lib/python3.10/site-packages/tests/__pycache__/test_eval_hook.cpython-310.pyc
python-mmpose /usr/lib/python3.10/site-packages/tests/__pycache__/test_post_processing.cpython-310.opt-1.pyc
python-mmpose /usr/lib/python3.10/site-packages/tests/__pycache__/test_post_processing.cpython-310.pyc
python-mmpose /usr/lib/python3.10/site-packages/tests/__pycache__/test_regularization.cpython-310.opt-1.pyc
python-mmpose /usr/lib/python3.10/site-packages/tests/__pycache__/test_regularization.cpython-310.pyc
python-mmpose /usr/lib/python3.10/site-packages/tests/__pycache__/test_utils.cpython-310.opt-1.pyc
python-mmpose /usr/lib/python3.10/site-packages/tests/__pycache__/test_utils.cpython-310.pyc
python-mmpose /usr/lib/python3.10/site-packages/tests/__pycache__/test_version.cpython-310.opt-1.pyc
python-mmpose /usr/lib/python3.10/site-packages/tests/__pycache__/test_version.cpython-310.pyc
python-mmpose /usr/lib/python3.10/site-packages/tests/__pycache__/test_visualization.cpython-310.opt-1.pyc
python-mmpose /usr/lib/python3.10/site-packages/tests/__pycache__/test_visualization.cpython-310.pyc
python-mmpose /usr/lib/python3.10/site-packages/tests/test_config.py
python-mmpose /usr/lib/python3.10/site-packages/tests/test_eval_hook.py
python-mmpose /usr/lib/python3.10/site-packages/tests/test_post_processing.py
python-mmpose /usr/lib/python3.10/site-packages/tests/test_regularization.py
python-mmpose /usr/lib/python3.10/site-packages/tests/test_utils.py
python-mmpose /usr/lib/python3.10/site-packages/tests/test_version.py
python-mmpose /usr/lib/python3.10/site-packages/tests/test_visualization.py

Reproduction

  • What command or script did you run?
python setup.py install
  • What config did you run?
A placeholder for the config.
  • Did you make any modifications on the code or config? Did you understand what you have modified?
  • What dataset did you use?

Environment

  1. Please run PYTHONPATH=${PWD}:$PYTHONPATH python mmpose/utils/collect_env.py to collect necessary environment information and paste it here.
  2. You may add addition that may be helpful for locating the problem, such as
  • How you installed PyTorch [e.g., pip, conda, source]
  • Other environment variables that may be related (such as $PATH, $LD_LIBRARY_PATH, $PYTHONPATH, etc.)

Error traceback

If applicable, paste the error traceback here.

A placeholder for traceback.

Bug fix

If you have already identified the reason, you can provide the information here. If you are willing to create a PR to fix it, please also leave a comment here and that would be much appreciated!

hubutui avatar Nov 12 '22 15:11 hubutui

Hi, thanks for using mmpose. We would recommend installing mmpose following the documents: https://mmpose.readthedocs.io/en/latest/install.html#installation

In short, it is commended to install mmpose via pip if you plan to use it as a 3rd-party package:

pip install mmpose

Or install mmpose from the source in the develop mode if you plan to modify its code:

git clone https://github.com/open-mmlab/mmpose
cd mmpose
pip install -e .

The approaches above should not include tests or other unnecessary files in the package directory.

ly015 avatar Nov 14 '22 08:11 ly015

I'm creating pkg for a Linux distribution (ArchLinux). I also extract the wheel file from pypi, it also contains tests folder in site-packages dir.

hubutui avatar Nov 14 '22 15:11 hubutui