mmpose icon indicating copy to clipboard operation
mmpose copied to clipboard

Add CID to mmpose

Open kennethwdk opened this issue 3 years ago • 5 comments

Motivation

Integrate CID (CVPR2022) into mmpose.

Modification

Modify dataset to add 'bbox' and 'area' into db_rec Modify pipeline to support transformation of 'bbox' and add CID target generator Add CID detector and head and configs. The code is adapted from here

The log and weights re-trained by mmpose are provided at here

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • [x] I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • [x] Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • [x] Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • [x] New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • [x] The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • [ ] CLA has been signed and all committers have signed the CLA in this PR.

kennethwdk avatar Aug 29 '22 06:08 kennethwdk

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 29 '22 06:08 CLAassistant

Thanks a lot for your contributions! We will review the codes ASAP.

jin-s13 avatar Aug 29 '22 11:08 jin-s13

Could you please follow the instructions here to setup the pre-commit? @kennethwdk

jin-s13 avatar Aug 29 '22 11:08 jin-s13

BTW, would you mind adding some unit tests for CID? You may refer to https://github.com/open-mmlab/mmpose/blob/master/tests/test_models/test_bottom_up_forward.py as an example.

jin-s13 avatar Aug 29 '22 11:08 jin-s13

Hello, I have created new commits to add the forward test, moving the losses and use pre-commit to check code styles.

kennethwdk avatar Sep 04 '22 07:09 kennethwdk

Hi, we retrain the CID model and get better performance.

Arch Input Size AP AP50 AP75 AR AR50
CID 512x512 0.702 0.887 0.768 0.755 0.926

The corresponding markdown file has been updated

Ben-Louis avatar Sep 29 '22 04:09 Ben-Louis

Hi @kennethwdk !First of all, we want to express our gratitude for your significant PR in the MMPose project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) Thank you again for your contribution❤

OpenMMLab-Assistant005 avatar Apr 07 '23 11:04 OpenMMLab-Assistant005