mmdetection icon indicating copy to clipboard operation
mmdetection copied to clipboard

add yolof init_cfg

Open twmht opened this issue 3 years ago • 2 comments
trafficstars

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Can't init yolof detector

Modification

Add init_cfg to yolof like other detectors

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  • [x] Pre-commit or other linting tools are used to fix the potential lint issues.
  • [x] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • [x] If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  • [x] The documentation has been modified accordingly, like docstring or example tutorials.

twmht avatar Jun 23 '22 02:06 twmht

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 23 '22 02:06 CLAassistant

Codecov Report

Base: 64.17% // Head: 64.19% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (eb6df23) compared to base (ca11860). Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8243      +/-   ##
==========================================
+ Coverage   64.17%   64.19%   +0.02%     
==========================================
  Files         361      361              
  Lines       29525    29525              
  Branches     5019     5019              
==========================================
+ Hits        18947    18955       +8     
+ Misses       9575     9565      -10     
- Partials     1003     1005       +2     
Flag Coverage Δ
unittests 64.17% <ø> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/models/detectors/yolof.py 83.33% <ø> (ø)
mmdet/models/dense_heads/corner_head.py 69.72% <0.00%> (+1.38%) :arrow_up:
mmdet/utils/misc.py 64.10% <0.00%> (+2.56%) :arrow_up:
mmdet/models/detectors/cornernet.py 100.00% <0.00%> (+5.12%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jun 25 '22 03:06 codecov[bot]