js-sdk icon indicating copy to clipboard operation
js-sdk copied to clipboard

feat(react): add FeatureFlag component

Open weyert opened this issue 7 months ago • 6 comments

This PR

Introduces the FeatureFlag component for React that allow using feature flags in a declarative manner

Related Issues

No ticket

Notes

Maybe consider adding a similar component for other supported frameworks?

Follow-up Tasks

How to test

I have written unit tests to cover the main features of the component

weyert avatar Apr 09 '25 00:04 weyert

Hey @weyert, could you please respond to the feedback when you have a moment? It looks like this change is almost ready and it would be great to get it out soon.

beeme1mr avatar Jul 18 '25 18:07 beeme1mr

Totally forgot about this PR. Having a look the coming days

weyert avatar Jul 19 '25 10:07 weyert

Keep making a mess of git history when I need to fix DCO :(

The changes I made were: https://github.com/open-feature/js-sdk/pull/1164/commits/b0fd0d7ff96a12e67d3213c185cbf1c5c3c6a830 https://github.com/open-feature/js-sdk/pull/1164/commits/c24b83f6ba4d464be9319e2dcca723cc8924ef08

I will see if I can fix the issue by merging main back into my branch

weyert avatar Jul 20 '25 17:07 weyert

I will see if I can fix the issue by merging main back into my branch

a handy little git command which i like to use in this situations

git reset $(git merge-base upstream/main $(git branch --show-current))

it will reset the branch to upstream main, but will keep all the changes ready to be committed again. replace upstream/main with the reference branch of your desire ;)

aepfli avatar Jul 21 '25 05:07 aepfli

@aepfli Thanks, I will try it out tomorrow. I might message you lol

weyert avatar Jul 21 '25 22:07 weyert

Your feedback should be addressed

weyert avatar Jul 22 '25 14:07 weyert