js-sdk-contrib icon indicating copy to clipboard operation
js-sdk-contrib copied to clipboard

Published 20 hours ago • verified publisher icon open-feature

feat: Create a Growthbook server side provider

Open msamper opened this issue 1 year ago • 4 comments

This PR

  • adds a new OpenFeature GrowthBook server provider

How to test

Integrate OpenFeature into a test node server and set it up with this new GrowthBook provider. Ensure that GrowthBook flag evaluation works as expected using the OpenFeature API

How to set up OpenFeature with node

OpenFeature.setProvider(new GrowthbookProvider(gbContext, initOptions))

msamper avatar Jun 07 '24 19:06 msamper

Hey @msamper, great addition, I will have a look tomorrow!

lukas-reining avatar Jun 10 '24 16:06 lukas-reining

Hi @msamper, could you please rebase this PR? It should resolve the E2E issue.

beeme1mr avatar Jun 10 '24 16:06 beeme1mr

Hi @msamper, could you please rebase this PR? It should resolve the E2E issue.

@beeme1mr I rebased on the main branch of my fork and it seems like there's still CI issues with the e2e and the lint-test-build. Should I be rebasing on open-feature:main instead?

msamper avatar Jun 12 '24 02:06 msamper

Hi @msamper, could you please rebase this PR? It should resolve the E2E issue.

@beeme1mr I rebased on the main branch of my fork and it seems like there's still CI issues with the e2e and the lint-test-build. Should I be rebasing on open-feature:main instead?

Yes, open-feature:main should be your branch to rebase on @msamper.

lukas-reining avatar Jun 14 '24 20:06 lukas-reining

We created a second version of our Node JS SDK that closely mirrors the Dynamic Context paradigm. I updated this PR to use it and fixed the tests. This should resolve the previously outstanding comments

msamper avatar Jan 08 '25 19:01 msamper

Looks good to me!

Great! Fixed up some variable names and updated the README so it should be good to merge

msamper avatar Jan 08 '25 21:01 msamper