js-sdk-contrib icon indicating copy to clipboard operation
js-sdk-contrib copied to clipboard

Published 20 hours ago • verified publisher icon open-feature

fix(flagsmith): Fetch identity flags when context changes

Open rolodato opened this issue 5 months ago • 4 comments

This PR

Use updated traits in the evaluation context whenever it changes.

Various README improvements.

Related Issues

Fixes #1232

Notes

N/A

Follow-up Tasks

Created an issue for the Flagsmith SDK to natively support Date objects: https://github.com/Flagsmith/flagsmith-js-client/issues/329

How to test

Added a failing test which is fixed by this PR.

rolodato avatar Jul 10 '25 20:07 rolodato

One for @kyle-ssg to have a look maybe? I can't assign reviewers for this PR while it's still in draft.

rolodato avatar Jul 10 '25 20:07 rolodato

Hey @rolodato, thanks for the PR. It looks like this PR only includes changes to the docs and a test. If that's intentional, I'm happy to review, but the PR description implies a larger change.

beeme1mr avatar Jul 11 '25 13:07 beeme1mr

Thanks @beeme1mr - there is actually a behavior change in this PR here, in case you missed it: https://github.com/open-feature/js-sdk-contrib/pull/1351/files#diff-6f058ad4a6f79177acf735cd905843b3a9f0a1f28e1493058d6dc3449a0fd3d2

rolodato avatar Jul 11 '25 15:07 rolodato

@Zaimwa9 does the PR we merged a few days ago address this issue?

beeme1mr avatar Oct 08 '25 18:10 beeme1mr