java-sdk-contrib icon indicating copy to clipboard operation
java-sdk-contrib copied to clipboard

[flagd-in-process] Support changed flag keys in the provider configuration change event

Open beeme1mr opened this issue 1 year ago • 2 comments

Overview

The flagd in-process provider will emit a change event when the flag configuration is updated. However, it does not include a list of flag keys that have changed. This makes it impossible to reevaluate a feature flag only when the configuration changes.

Requirements

  • Include a list of change flags in the provider configuration changed event: https://github.com/open-feature/java-sdk-contrib/blob/main/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java#L174
  • A flag is considered changed if it has been added, removed, or updated.
  • Associated tests

Note

This functionality is supported in JavaScript. The PR can be found here.

beeme1mr avatar Aug 05 '24 17:08 beeme1mr

@toddbaert sure this looks good, will work on it 👍. Thanks

UtkarshSharma2612 avatar Aug 15 '24 14:08 UtkarshSharma2612

@toddbaert sure this looks good, will work on it 👍. Thanks

Assigned!

toddbaert avatar Aug 15 '24 14:08 toddbaert

Hey @toddbaert, I am trying to push the code using personal access token, but it is showing access denied. Do I need a fine-grained token to access and push the code in the new branch which I created on local? remote: Permission to open-feature/java-sdk-contrib.git denied to UtkarshSharma2612. fatal: unable to access 'https://github.com/open-feature/java-sdk-contrib.git/': The requested URL returned error: 403

UtkarshSharma2612 avatar Aug 24 '24 08:08 UtkarshSharma2612

Hey @UtkarshSharma2612, you should fork this repo and make your changes there. You can then open a pr from the fork once you're ready.

beeme1mr avatar Aug 24 '24 13:08 beeme1mr

Hey @UtkarshSharma2612, you should fork this repo and make your changes there. You can then open a pr from the fork once you're ready.

Thanks @beeme1mr, I have also raised pr https://github.com/open-feature/java-sdk-contrib/pull/925, I am yet to write test-cases, can you help with the preliminary review of the pr to see if the approach is correct.

UtkarshSharma2612 avatar Aug 24 '24 13:08 UtkarshSharma2612