java-sdk-contrib
java-sdk-contrib copied to clipboard
feat(optimizely)!: Optimizely provider concepts updates
Summary of Changes
Hello @liran2000, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refactors the Optimizely Java provider to enhance its feature flag evaluation capabilities and align with the concepts established in the Go provider. The changes enable direct support for various data types in flag evaluations and introduce a flexible way to select specific variables within Optimizely flags, thereby improving the provider's functionality and consistency across different OpenFeature SDKs.
Highlights
- Direct Evaluation Support: The Optimizely provider now directly supports String, Integer, and Double flag evaluations, moving away from throwing
UnsupportedOperationExceptionfor these types. - Variable Key Selection: A new mechanism has been introduced to allow specifying a
variableKeywithin theEvaluationContextto select a particular variable from an Optimizely feature flag, defaulting to 'value' if not specified. - Updated Evaluation Logic: All evaluation methods (
getBooleanEvaluation,getStringEvaluation,getIntegerEvaluation,getDoubleEvaluation,getObjectEvaluation) have been refactored to use specific Optimizely SDKgetFeatureVariableXmethods, improving precision and alignment with Optimizely's variable concepts. - Enhanced Documentation and Tests: The
README.mdhas been updated to reflect the new evaluation concepts, and comprehensive unit tests have been added and modified to cover the new functionality, includingvariableKeyusage and default value handling.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.