PyPartMC icon indicating copy to clipboard operation
PyPartMC copied to clipboard

Switch PyPartMC's binding system from pybind11 to nanobind

Open Griger5 opened this issue 6 months ago • 1 comments
trafficstars

Griger5 avatar May 09 '25 18:05 Griger5

thank you @Griger5 !

slayoo avatar May 09 '25 20:05 slayoo

This PR:

  • makes #414 obsolete
  • addresses #403
  • potentially helps with:
    • #368,
    • #348,
    • #334,
    • #213
    • #99
    • #413

slayoo avatar Jun 04 '25 10:06 slayoo

The Matlab build fails with:

  Cannot find class 'py.nanobind.nb_type_0'.

should we ask at nanobind discussions? (referencing https://github.com/wjakob/nanobind/discussions/439)

slayoo avatar Jul 23 '25 13:07 slayoo

BTW, the only place where Google indexed seemingly identical error as we have in the codecov build is here: https://github.com/nvidia-isaac/nvblox/issues/73

slayoo avatar Jul 30 '25 00:07 slayoo

Codecov Report

:x: Patch coverage is 95.50562% with 4 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 90.38%. Comparing base (1da8001) to head (8d62e78). :warning: Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/pypartmc.cpp 94.59% 4 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
- Coverage   90.76%   90.38%   -0.38%     
==========================================
  Files          55       55              
  Lines        2491     2455      -36     
  Branches      135      139       +4     
==========================================
- Hits         2261     2219      -42     
- Misses        158      163       +5     
- Partials       72       73       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Jul 30 '25 10:07 codecov-commenter