PyPartMC icon indicating copy to clipboard operation
PyPartMC copied to clipboard

Enable nucleation

Open jcurtis2 opened this issue 2 years ago • 6 comments

Currently we have nucleation not able to be enabled. This problem will most likely change/disappear when PartMC is rewritten for https://github.com/compdyn/partmc/issues/184.

However to fix the issue now, RunPartOpt will need access to AeroData to modify the number of weight classes (and subsequent tests will need to be fixed to include this input.).

jcurtis2 avatar May 17 '23 16:05 jcurtis2

Support also probably needs to consider a longtime existing issue of what to do here: https://github.com/compdyn/partmc/issues/65

PyPartMC only uses NUMMASS_SOURCE weighting (which is most efficient except in the case of nucleation enabled). This weight choice should be relaxed by passing additional details in the json input to RunPartOpt.

jcurtis2 avatar May 17 '23 17:05 jcurtis2

Stale issue message

github-actions[bot] avatar Jul 17 '23 13:07 github-actions[bot]

Stale issue message

github-actions[bot] avatar Sep 19 '23 13:09 github-actions[bot]

Stale issue message

github-actions[bot] avatar Nov 29 '23 13:11 github-actions[bot]

Stale issue message

github-actions[bot] avatar Feb 05 '24 13:02 github-actions[bot]

https://github.com/compdyn/partmc/pull/188

slayoo avatar May 21 '24 17:05 slayoo