PyPartMC icon indicating copy to clipboard operation
PyPartMC copied to clipboard

multi-mode dist modes are returned back in reverse order wrt the ctor input

Open slayoo opened this issue 2 years ago • 6 comments

image

slayoo avatar May 17 '23 15:05 slayoo

Added a test here that will cause the issue: https://github.com/open-atmos/PyPartMC/pull/207/commits/bede72e68baf5909ffbb4170c862619d2bb6ee10

Looks like its sorting them in alphabetical order.

jcurtis2 avatar May 18 '23 04:05 jcurtis2

This is linked with a logic embedded in our JSON backend package: https://github.com/nlohmann/json#order-of-object-keys There is already a workaround available there, but the pybind11_json bridge that we use does not support it yet. Reported: https://github.com/pybind/pybind11_json/issues/63

slayoo avatar May 18 '23 10:05 slayoo

Stale issue message

github-actions[bot] avatar Jul 17 '23 13:07 github-actions[bot]

Stale issue message

github-actions[bot] avatar Sep 19 '23 13:09 github-actions[bot]

Stale issue message

github-actions[bot] avatar Nov 29 '23 13:11 github-actions[bot]

Stale issue message

github-actions[bot] avatar Feb 05 '24 13:02 github-actions[bot]