ookii-dialogs-wpf icon indicating copy to clipboard operation
ookii-dialogs-wpf copied to clipboard

Published 20 hours ago • verified publisher icon ookii-dialogs

Use Microsoft.Windows.CsWin32 to generate P/Invoke methods

Open virzak opened this issue 3 years ago • 4 comments
trafficstars

virzak avatar Dec 15 '21 21:12 virzak

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 15 '21 21:12 CLAassistant

Thanks for the PR @virzak ! 👍🏻

Could you create an issue in this repo with the elevator pitch for moving to CsWin32 on this library? I'm definitely not against it, but I'd like to understand the value we get given all the P/Invoke definitions have already been written and have been battle tested for many years.

Also, if we were to go this route, would we be able to use a stable version of the Microsoft.Windows.CsWin32 package directly from the nuget.org feed?

augustoproiete avatar Dec 16 '21 00:12 augustoproiete

Logged #85.

Yes, the nuget.org version works as well. Something wasn't working during development and I just tried the latest build of the library. Turned out it wasn't at fault. If you'd like I can revert.

virzak avatar Dec 16 '21 00:12 virzak

Now using the latest version from nuget instead of a private feed.

virzak avatar Feb 04 '22 04:02 virzak

@augustoproiete, any chance of merging this soon? I'd like to submit another PR which conflicts with this, so if you have a chance to look at this soon, it would avoid future conflict.

virzak avatar Sep 27 '22 18:09 virzak

@virzak Merged. Sorry for the long delay

augustoproiete avatar Sep 28 '22 18:09 augustoproiete