ElasticsearchDSL icon indicating copy to clipboard operation
ElasticsearchDSL copied to clipboard

PHP 8 support

Open matchish opened this issue 4 years ago • 7 comments

It will be great to add php8 support(as dependency) https://www.php.net/releases/8.0/en.php

matchish avatar Dec 12 '20 09:12 matchish

@saimaz Could you please bump this package? Don't why the open PR has changes, does this really rewriting for PHP 8?

francoism90 avatar Jan 29 '21 12:01 francoism90

Hello,

Any news on this issue? It's really important to support PHP 8 since it's used in production quite a lot now.

Thanks!

guicara avatar May 02 '21 15:05 guicara

As a temporary workaround, I published https://packagist.org/packages/ocramius/elasticsearch-dsl#7.9.999

This allows usage within my local infrastructure, but it comes with ZERO BC promise, since I'd rather see it deleted when @ongr-io releases a compatible version :-)

Ocramius avatar May 26 '21 09:05 Ocramius

Or just use https://github.com/handcraftedinthealps/elasticsearchdsl. It‘s maintained by the guys of sulu so it‘s in good hands i guess. Also supports symfony5 and php8.

solverat avatar May 26 '21 21:05 solverat

That's something I've already done, but we should support @ongr-io first.

Ocramius avatar May 27 '21 08:05 Ocramius

hey, i'm currently testing the php8 integration with a local project, will try to release a version with support soonish. Changes are on https://github.com/ongr-io/ElasticsearchDSL/tree/7.2 already i just need to test it and the release the next version (maybe i'll copy a release pipeline from one of @Ocramius projects for that - but i don't have that much experience with github actions yet)

84m avatar May 27 '21 08:05 84m

@84m feel free to poke/call me if you need any guidance: anything that brings this lib forward is immediate value :-)

Alternatively, check https://github.com/laminas/laminas-continuous-integration-action, which does a bunch of checks, all in one shot.

Ocramius avatar May 27 '21 08:05 Ocramius