flow-go
flow-go copied to clipboard
[Malleability Immutable] Enforce immutability for Block (cluster)
Please do not review this PR. It is in progress.
Closes: #7277
Changes
- Added
UntrustedBlockmodel. - Added
cluster.Blockvalidations for constructor. - Added unit tests for constructor.
- Updated constructor for
cluster.Payloadto useUntrustedmodel to be consistent with other constructors. - Added unit tests for
cluster.Payloadconstructor. - Removed unused
SyncedBlockandSyncedClusterBlocktypes. - Removed unused
UntrustedBlocktype frommodel/messages/consensus.go.
Codecov Report
Attention: Patch coverage is 44.54545% with 122 lines in your changes missing coverage. Please review.
Project coverage is 41.34%. Comparing base (
fbd8690) to head (f29a207).
Additional details and impacted files
@@ Coverage Diff @@
## feature/malleability #7553 +/- ##
========================================================
+ Coverage 40.30% 41.34% +1.04%
========================================================
Files 2121 2187 +66
Lines 186907 193795 +6888
========================================================
+ Hits 75325 80123 +4798
- Misses 105272 106988 +1716
- Partials 6310 6684 +374
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 41.34% <44.54%> (+1.04%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.