flow-go icon indicating copy to clipboard operation
flow-go copied to clipboard

Malleabilty-master sync

Open tim-barry opened this issue 5 months ago • 1 comments

Resolve merge conflicts prior to the malleability merge.

Conflicts in:

  • consensus/integration/nodes_test.go
  • engine/collection/test/cluster_switchover_test.go
  • integration/testnet/network.go
  • module/mempool/consensus/exec_fork_suppressor_test.go
  • state/protocol/badger/snapshot_test.go

Changes to new files (updating usages of unittest.BlockFixture and Block.ToHeader()):

  • module/state_synchronization/requester/oneshot_execution_data_requester_test.go
  • storage/operation/execution_fork_evidence_test.go
  • storage/store/execution_fork_evidence_test.go

tim-barry avatar Jun 10 '25 20:06 tim-barry

Codecov Report

Attention: Patch coverage is 64.94681% with 659 lines in your changes missing coverage. Please review.

Project coverage is 41.33%. Comparing base (08bb77f) to head (383f34f).

Files with missing lines Patch % Lines
fvm/evm/testutils/backend.go 30.97% 63 Missing and 15 partials :warning:
storage/operation/badgerimpl/writer.go 0.00% 38 Missing :warning:
...state_synchronization/indexer/in_memory_indexer.go 66.66% 25 Missing and 12 partials :warning:
fvm/environment/crypto_library.go 0.00% 36 Missing :warning:
storage/operation/dbtest/helper.go 0.00% 34 Missing :warning:
model/bootstrap/node_info.go 23.80% 31 Missing and 1 partial :warning:
storage/store/transaction_results.go 52.30% 30 Missing and 1 partial :warning:
storage/mock/node_disallow_list.go 0.00% 30 Missing :warning:
utils/unittest/fixtures.go 9.09% 30 Missing :warning:
fvm/environment/account_info.go 0.00% 23 Missing :warning:
... and 49 more
Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature/malleability    #7496      +/-   ##
========================================================
+ Coverage                 41.17%   41.33%   +0.16%     
========================================================
  Files                      2182     2186       +4     
  Lines                    192835   193661     +826     
========================================================
+ Hits                      79396    80056     +660     
- Misses                   106786   106932     +146     
- Partials                   6653     6673      +20     
Flag Coverage Δ
unittests 41.33% <64.94%> (+0.16%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Jun 10 '25 20:06 codecov-commenter