[Storage] Use lockctx to store approvals

[zhangchiqing]

Working towards https://github.com/onflow/flow-go/issues/7355. This PR addresses part of the second category:

2. Existing usage of a lock within the storage layer (currently marked with TODO(7355) in https://github.com/onflow/flow-go/issues/7138)

This PR introduces the lockctx manager and uses it in storing the approvals. The lockctx manager helps to ensure we don't overwrite conflicting approvals for the same block.

This PR also removes the deprecated badger transaction models that stores approvals.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 34.86842% with 99 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
engine/testutil/nodes.go	0.00%	17 Missing :warning:
cmd/scaffold.go	0.00%	10 Missing :warning:
storage/operation/approvals.go	0.00%	10 Missing :warning:
storage/locks/factory.go	42.85%	8 Missing :warning:
storage/store/approvals.go	63.63%	5 Missing and 3 partials :warning:
utils/unittest/unittest.go	0.00%	8 Missing :warning:
follower/consensus_follower.go	0.00%	7 Missing :warning:
follower/follower_builder.go	0.00%	7 Missing :warning:
cmd/verification_builder.go	0.00%	6 Missing :warning:
engine/verification/verifier/engine.go	60.00%	4 Missing and 2 partials :warning:
... and 3 more

:loudspeaker: Thoughts on this report? Let us know!

[jordanschalm]

Hey @zhangchiqing, it looks like this PR is replicating many of the changes added in https://github.com/onflow/flow-go/pull/7364, but in different commits without sharing Git history. Can you explain which set of changes you're planning to eventually include in master? From my perspective, it would make the most sense for this PR adding the Approvals storage module changes to extend https://github.com/onflow/flow-go/pull/7364, where lockctx is added.

If possible, I want to avoid a situation where we are simultaneously reviewing and modifying the same set of changes in two different PRs (this one and https://github.com/onflow/flow-go/pull/7364), because it's difficult to keep them consistent.

[zhangchiqing]

@jordanschalm yeah, https://github.com/onflow/flow-go/pull/7364 is gonna be merged to feature branch, and stay there for a while. But I think the lock manager could be merged to master earlier, before the feature branch gets merged.

It's hard to cherry-pick your changes from 7364 into this PR, I tried but doesn't work, only managed to cherry-pick one commit. For the rest, I had to copy over the changes into this PR.