flow-go icon indicating copy to clipboard operation
flow-go copied to clipboard

Random beacon comments

Open tarakby opened this issue 1 year ago • 1 comments
trafficstars

Updates to the DKG/Random beacon related docs:

  • clarify that the set (the set of nodes able to participate in the random beacon) is a subset of 𝒟 ∩ 𝒞.
  • clarify that the protocol software implements a sanity check but does not guarantee that |ℛ| is in the safe range.
  • minor clarifications about the DKG results and indices

tarakby avatar Oct 23 '24 00:10 tarakby

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 41.71%. Comparing base (af44dde) to head (b0f36be).

Files with missing lines Patch % Lines
model/convert/service_event.go 0.00% 7 Missing :warning:
cmd/bootstrap/run/qc.go 0.00% 1 Missing :warning:
...nsus/hotstuff/verification/combined_verifier_v3.go 0.00% 1 Missing :warning:
Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature/efm-recovery    #6590      +/-   ##
========================================================
- Coverage                 41.71%   41.71%   -0.01%     
========================================================
  Files                      2030     2030              
  Lines                    180459   180459              
========================================================
- Hits                      75272    75271       -1     
- Misses                    98991    98995       +4     
+ Partials                   6196     6193       -3     
Flag Coverage Δ
unittests 41.71% <25.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 23 '24 00:10 codecov-commenter