flow-go
flow-go copied to clipboard
onflow
Disable adx in util build
util is cross-built, by taking into account the build machine support for ADX. This causes an issue when the build machine supports ADX and the target machine doesn't.
This PR disables ADX in the built image so that the image works regardless of ADX support. This comes with a slight performance impact, which doesn't seem to be an issue for util.
Note that the image only works for the same arch as the build machine.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 41.10%. Comparing base (
13dd041) to head (46bcdda).
Additional details and impacted files
@@ Coverage Diff @@
## master #6580 +/- ##
==========================================
+ Coverage 41.09% 41.10% +0.01%
==========================================
Files 2020 2020
Lines 178571 178571
==========================================
+ Hits 73375 73395 +20
+ Misses 99042 99026 -16
+ Partials 6154 6150 -4
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 41.10% <ø> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The fix has been successfully tested by me and an external VN node operator.
