[Access] Backport transaction insufficient balance

[Guitarheroua]

Close https://github.com/onflow/flow-go/issues/6449

Backport implementation of filtering out transactions with insufficient transaction fees

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 28.18627% with 293 lines in your changes missing coverage. Please review.

Project coverage is 41.55%. Comparing base (99b91c5) to head (ca92383). Report is 2 commits behind head on v0.37.

Files with missing lines	Patch %	Lines
cmd/access/node_builder/access_node_builder.go	0.00%	54 Missing :warning:
access/validator.go	48.45%	46 Missing and 4 partials :warning:
cmd/observer/node_builder/observer_builder.go	0.00%	35 Missing :warning:
engine/access/mock/execution_api_client.go	0.00%	29 Missing :warning:
module/metrics/transaction_validation.go	0.00%	27 Missing :warning:
engine/access/mock/execution_api_server.go	0.00%	22 Missing :warning:
access/mock/blocks.go	0.00%	21 Missing :warning:
module/mock/transaction_validation_metrics.go	0.00%	12 Missing :warning:
...tasync/execution_data/processed_height_recorder.go	0.00%	11 Missing :warning:
engine/common/stop/stop_control.go	90.62%	5 Missing and 1 partial :warning:
... and 7 more

Additional details and impacted files

@@            Coverage Diff             @@
##            v0.37    #6549      +/-   ##
==========================================
- Coverage   41.56%   41.55%   -0.02%     
==========================================
  Files        2023     2026       +3     
  Lines      180764   181081     +317     
==========================================
+ Hits        75141    75248     +107     
- Misses      99388    99607     +219     
+ Partials     6235     6226       -9     

Flag	Coverage Δ
unittests	41.55% <28.18%> (-0.02%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[peterargue]

Looks like there are some compiler errors in the integration tests

Error: ../engine/execution/rpc/engine.go:120:51: cannot use eng.handler (variable of type *handler) as "github.com/onflow/flow/protobuf/go/flow/execution".ExecutionAPIServer value in argument to execution.RegisterExecutionAPIServer: *handler does not implement "github.com/onflow/flow/protobuf/go/flow/execution".ExecutionAPIServer (missing method GetTransactionExecutionMetricsAfter)
Error: ../engine/execution/rpc/engine.go:172:38: cannot use (*handler)(nil) (value of type *handler) as "github.com/onflow/flow/protobuf/go/flow/execution".ExecutionAPIServer value in variable declaration: *handler does not implement "github.com/onflow/flow/protobuf/go/flow/execution".ExecutionAPIServer (missing method GetTransactionExecutionMetricsAfter)

[peterargue]

@Guitarheroua can you take a look at the compiler errors and conflict?

[Guitarheroua]

@Guitarheroua can you take a look at the compiler errors and conflict?

Looks like these errors come from my dependencies in integration tests, that I backported.

How should I proceed in this case? Should I just find relevant dependencies?

[peterargue]

@janezpodhostnik looks like the missing dependencies are from the GetTransactionExecutionMetricsAfter endpoint. Is that OK to backport to v0.37?

[zhangchiqing]

Which one is the original PR that we are backporting from?

[peterargue]

@zhangchiqing there are 3 PRs. I updated the description with the list

[Guitarheroua]

@zhangchiqing there are 3 PRs. I updated the description with the list

Also this one https://github.com/onflow/flow-go/pull/6202. Added to description