flow-go icon indicating copy to clipboard operation
flow-go copied to clipboard

[Execution] Remove deprecated ingestion engine

Open zhangchiqing opened this issue 1 year ago • 1 comments

The new execution ingestion engine has been enabled by default. It's been running for over 4 months now since May (v0.33.27) on mainnet EN1 and EN2. The old ingestion engine has been deprecated, and can now be removed.

This PR removes the deprecated execution ingestion engine. It fixes a few test cases that were using the deprecated ingestion engine to use the new ingestion engine. No logic changes.

zhangchiqing avatar Sep 27 '24 22:09 zhangchiqing

Codecov Report

Attention: Patch coverage is 23.07692% with 20 lines in your changes missing coverage. Please review.

Project coverage is 41.00%. Comparing base (53a2bca) to head (231d260). Report is 249 commits behind head on master.

Files with missing lines Patch % Lines
engine/testutil/nodes.go 0.00% 8 Missing :warning:
cmd/execution_builder.go 0.00% 7 Missing :warning:
cmd/execution_config.go 0.00% 3 Missing :warning:
engine/execution/ingestion/machine.go 0.00% 1 Missing :warning:
engine/testutil/mock/nodes.go 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6510      +/-   ##
==========================================
- Coverage   41.14%   41.00%   -0.14%     
==========================================
  Files        2020     2018       -2     
  Lines      178778   178127     -651     
==========================================
- Hits        73555    73044     -511     
+ Misses      99062    98969      -93     
+ Partials     6161     6114      -47     
Flag Coverage Δ
unittests 41.00% <23.07%> (-0.14%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 27 '24 22:09 codecov-commenter