flow-go
flow-go copied to clipboard
[Access] Refactor executionNodesForBlockID by encapsulating its parameters into a struct
Closes: #6497
Context
This pull request introduces a new struct, ExecutionNodeIdentitiesProvider, which encapsulates the parameters previously passed around multiple functions. This struct is initialized during instance creation and includes fields for executionReceipts, state,preferredENIdentifiers, fixedENIdentifiers and other relevant data.
Changes:
- Created a new
ExecutionNodeIdentitiesProviderstruct. - Refactored
executionNodesForBlockIDand related functions to use the new struct instead of individual parameters. - Updated relevant unit tests to reflect the changes in function signatures and verify the new implementation.
Codecov Report
Attention: Patch coverage is 41.55844% with 90 lines in your changes missing coverage. Please review.
Project coverage is 41.19%. Comparing base (
36f067d) to head (54ffb07).
Additional details and impacted files
@@ Coverage Diff @@
## master #6499 +/- ##
==========================================
+ Coverage 41.14% 41.19% +0.04%
==========================================
Files 2036 2036
Lines 179997 179972 -25
==========================================
+ Hits 74060 74134 +74
+ Misses 99720 99613 -107
- Partials 6217 6225 +8
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 41.19% <41.55%> (+0.04%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.