flow-go icon indicating copy to clipboard operation
flow-go copied to clipboard

V0.33.8 relic

Open tarakby opened this issue 1 year ago • 1 comments

⚠️ Do not merge. This is only a draft to see differences against v0.33.

Branch v0.33.8-relic was branched off tag v0.33.8. It downgrades the crypto version from v0.25.0 (blst-based) to v0.24.10-.. (relic-based) to address CPU compatibility issues with node operators running on Intel haswell no TSX

Note that the v0.24.10-.. crypto version is not a tagged version. It is a commit from branch https://github.com/onflow/flow-go/tree/crypto/v0.24.9-no-build-tag which removes the need to use a Go build tag -tags=relic

tarakby avatar Feb 28 '24 02:02 tarakby

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.35%. Comparing base (bf54231) to head (affc4ef). Report is 22 commits behind head on v0.33.

Additional details and impacted files
@@            Coverage Diff             @@
##            v0.33    #5471      +/-   ##
==========================================
- Coverage   56.75%   55.35%   -1.40%     
==========================================
  Files         812      967     +155     
  Lines       79921    93026   +13105     
==========================================
+ Hits        45356    51499    +6143     
- Misses      31104    37665    +6561     
- Partials     3461     3862     +401     
Flag Coverage Δ
unittests 55.35% <ø> (-1.40%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 28 '24 02:02 codecov-commenter