flow-go
flow-go copied to clipboard
Atree Inlining & Deduplication with Cadence v0.42
Do not merge. This PR is to be used for building migration program needed by spork and running benchmarks.
This enables Atree Inlining & Deduplication with Cadence 0.42 in flow-go (e.g. atree migration program, etc.).
- Epic https://github.com/onflow/atree/issues/292
- Cadence 0.42 Integration https://github.com/onflow/cadence/pull/2882
TODO:
- [x] Investigate flakey tests (flakes were unrelated to atree storage)
- [x] Fix compatibility of tests with atree inlining
OPTIONAL TODO:
-
[ ] Update to get recent changes to the migration program
- [ ] https://github.com/onflow/flow-go/pull/5386
NOTE: Using intermediate payload file during real migration has become low priority (optional) because enabling atree inlining reduces duration of migration (due to reduced node count, payload count, total data size, etc.) :tada:
UPDATES:
- Resumed work on this on Feb 1 after helping with related work on https://github.com/onflow/cadence/pull/3048
- Based on Feb 12 meetings, no more changes are needed to this PR unless we need migration-related bug fixes applied.
Codecov Report
Attention: Patch coverage is 70.47170% with 313 lines in your changes are missing coverage. Please review.
Project coverage is 56.80%. Comparing base (
f0b7f2a) to head (a3d758e).
Additional details and impacted files
@@ Coverage Diff @@
## feature/atree-inlining-cadence-v0.42 #5349 +/- ##
========================================================================
+ Coverage 55.63% 56.80% +1.16%
========================================================================
Files 1002 664 -338
Lines 96600 63368 -33232
========================================================================
- Hits 53745 35994 -17751
+ Misses 38800 24781 -14019
+ Partials 4055 2593 -1462
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 56.80% <70.47%> (+1.16%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR was useful for fast updates to avoid workflow bottlenecks like unrelated test flakes, etc.
Closed by PR #5736 which will be easier for PR reviewers, etc.