flow-go icon indicating copy to clipboard operation
flow-go copied to clipboard

Atree Inlining & Deduplication with Cadence v0.42

Open fxamacker opened this issue 1 year ago • 1 comments

Do not merge. This PR is to be used for building migration program needed by spork and running benchmarks.

This enables Atree Inlining & Deduplication with Cadence 0.42 in flow-go (e.g. atree migration program, etc.).

  • Epic https://github.com/onflow/atree/issues/292
  • Cadence 0.42 Integration https://github.com/onflow/cadence/pull/2882

TODO:

  • [x] Investigate flakey tests (flakes were unrelated to atree storage)
  • [x] Fix compatibility of tests with atree inlining

OPTIONAL TODO:

  • [ ] Update to get recent changes to the migration program

    • [ ] https://github.com/onflow/flow-go/pull/5386

    NOTE: Using intermediate payload file during real migration has become low priority (optional) because enabling atree inlining reduces duration of migration (due to reduced node count, payload count, total data size, etc.) :tada:

UPDATES:

  • Resumed work on this on Feb 1 after helping with related work on https://github.com/onflow/cadence/pull/3048
  • Based on Feb 12 meetings, no more changes are needed to this PR unless we need migration-related bug fixes applied.

fxamacker avatar Feb 02 '24 23:02 fxamacker

Codecov Report

Attention: Patch coverage is 70.47170% with 313 lines in your changes are missing coverage. Please review.

Project coverage is 56.80%. Comparing base (f0b7f2a) to head (a3d758e).

Files Patch % Lines
engine/access/rpc/backend/script_executor.go 0.00% 49 Missing :warning:
fvm/evm/emulator/state/collection.go 14.28% 33 Missing and 3 partials :warning:
fvm/evm/emulator/emulator.go 71.56% 23 Missing and 6 partials :warning:
engine/collection/ingest/rate_limiter.go 68.91% 22 Missing and 1 partial :warning:
fvm/evm/types/call.go 0.00% 20 Missing :warning:
engine/access/rpc/backend/events_index.go 64.15% 17 Missing and 2 partials :warning:
fvm/evm/handler/blockstore.go 57.77% 13 Missing and 6 partials :warning:
fvm/evm/handler/handler.go 81.63% 16 Missing and 2 partials :warning:
fvm/evm/stdlib/contract.go 68.96% 13 Missing and 5 partials :warning:
fvm/evm/types/blockHashList.go 89.56% 8 Missing and 4 partials :warning:
... and 22 more
Additional details and impacted files
@@                           Coverage Diff                            @@
##           feature/atree-inlining-cadence-v0.42    #5349      +/-   ##
========================================================================
+ Coverage                                 55.63%   56.80%   +1.16%     
========================================================================
  Files                                      1002      664     -338     
  Lines                                     96600    63368   -33232     
========================================================================
- Hits                                      53745    35994   -17751     
+ Misses                                    38800    24781   -14019     
+ Partials                                   4055     2593    -1462     
Flag Coverage Δ
unittests 56.80% <70.47%> (+1.16%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 08 '24 00:02 codecov-commenter

This PR was useful for fast updates to avoid workflow bottlenecks like unrelated test flakes, etc.

Closed by PR #5736 which will be easier for PR reviewers, etc.

fxamacker avatar Apr 19 '24 13:04 fxamacker