flow-go-sdk icon indicating copy to clipboard operation
flow-go-sdk copied to clipboard

refactor subscribe func and stream mock object

Open illia-malachyn opened this issue 1 year ago • 2 comments

Closes: #763

illia-malachyn avatar Oct 17 '24 10:10 illia-malachyn

@peterargue cc

illia-malachyn avatar Oct 17 '24 10:10 illia-malachyn

Codecov Report

Attention: Patch coverage is 78.37838% with 24 lines in your changes missing coverage. Please review.

Project coverage is 56.59%. Comparing base (9f84549) to head (e2f4c9d). Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
access/grpc/grpc.go 83.65% 14 Missing and 3 partials :warning:
access/grpc/convert/convert.go 0.00% 5 Missing :warning:
account.go 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
- Coverage   57.04%   56.59%   -0.46%     
==========================================
  Files          35       35              
  Lines        7391     7305      -86     
==========================================
- Hits         4216     4134      -82     
+ Misses       2673     2670       -3     
+ Partials      502      501       -1     
Flag Coverage Δ
unittests 56.59% <78.37%> (-0.46%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 17 '24 10:10 codecov-commenter

@illia-malachyn looks good. please merge master

peterargue avatar Nov 01 '24 18:11 peterargue