flow-emulator icon indicating copy to clipboard operation
flow-emulator copied to clipboard

fix: fix slice init length

Open davidwoood opened this issue 1 year ago • 1 comments

Description

The intention here should be to initialize a slice with a capacity of value.Count() rather than initializing the length of this slice.

The online demo: https://go.dev/play/p/q1BcVCmvidW


For contributor use:

  • [x] Targeted PR against master branch
  • [x] Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • [ ] Code follows the standards mentioned here
  • [ ] Updated relevant documentation
  • [ ] Re-reviewed Files changed in the GitHub PR explorer
  • [ ] Added appropriate labels

davidwoood avatar Oct 25 '24 16:10 davidwoood

thank you for fixing this @davidwoood

bluesign avatar Oct 28 '24 11:10 bluesign

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 34.50%. Comparing base (96c4f80) to head (058ba6e). Report is 35 commits behind head on master.

Files with missing lines Patch % Lines
server/debugger/debugsession.go 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #766      +/-   ##
==========================================
- Coverage   35.30%   34.50%   -0.80%     
==========================================
  Files          47       45       -2     
  Lines        7418     7320      -98     
==========================================
- Hits         2619     2526      -93     
  Misses       4610     4610              
+ Partials      189      184       -5     
Flag Coverage Δ
unittests 34.50% <0.00%> (-0.80%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 29 '24 13:10 codecov-commenter

@janezpodhostnik can you merge this one, I don't have permission

bluesign avatar Dec 12 '24 16:12 bluesign