flow-core-contracts icon indicating copy to clipboard operation
flow-core-contracts copied to clipboard

Update Core Contracts to be compatible with Stable Cadence

Open dsainati1 opened this issue 3 years ago • 1 comments

Problem

https://github.com/onflow/flow-core-contracts/blob/master/contracts/LockedTokens.cdc#L231

The linked code does not behave the way it appears to; the as? in this line does not actually function as a reference operator. In a future version of Cadence this code will be rejected by the typechecker.

Steps to Reproduce

Typecheck this contract on the master version of Cadence.

dsainati1 avatar Jul 05 '22 18:07 dsainati1

I've made a PR to address stable cadence changes: https://github.com/onflow/flow-core-contracts/pull/319

joshuahannan avatar Nov 02 '22 18:11 joshuahannan

@joshuahannan I guess this is complete and can be closed?

turbolent avatar May 02 '24 18:05 turbolent

yeah

joshuahannan avatar May 02 '24 18:05 joshuahannan