react-tailwindcss-datepicker icon indicating copy to clipboard operation
react-tailwindcss-datepicker copied to clipboard

Duplicated week days bug

Open DreamDevourer opened this issue 1 year ago • 1 comments

Hi, this is weird, but it seems this bug is also happening on the demo page and on my local project:

Screenshot 2024-09-02 at 11 10 13 PM Screenshot 2024-09-02 at 11 10 40 PM

Wednesday is duplicated and Saturday does not show up at all. Why this is happening?

DreamDevourer avatar Sep 03 '24 02:09 DreamDevourer

Oh wow, actually this is completely unstable - If I jump on Safari or Firefox, the result is completely different. On Safari, it only shows "Wed Thu Fri" at the end, and all the other are missing for some reason. Something similar happens on Firefox, only difference is that Sunday and Monday are missing.

Both screenshots I sent before were from Arc - which is a chromium based browser...

DreamDevourer avatar Sep 03 '24 02:09 DreamDevourer

@onesine any thoughts on this issue?

ian-whitestone avatar Oct 21 '24 15:10 ian-whitestone

The error occurs because the week is iterated using the JavaScript Date constructor as a string, which causes variations between the actual day.

Example of how it's iterated and its result:

new Date('2022-11-6')  // -> Sun Nov 06 2022 00:00:00 GMT-0600
new Date('2022-11-7')  // -> Mon Nov 07 2022 00:00:00 GMT-0600
new Date('2022-11-8')  // -> Tue Nov 08 2022 00:00:00 GMT-0600
new Date('2022-11-9')  // -> Wed Nov 09 2022 00:00:00 GMT-0600
new Date('2022-11-10') // -> Wed Nov 09 2022 18:00:00 GMT-0600
new Date('2022-11-11') // -> Thu Nov 10 2022 18:00:00 GMT-0600
new Date('2022-11-12') // -> Fri Nov 11 2022 18:00:00 GMT-0600

If we iterate using the Date(year, month, day) constructor, these variations do not occur:

new Date(2022,10,6)  // -> Sun Nov 06 2022 00:00:00 GMT-0600
new Date(2022,10,7)  // -> Mon Nov 07 2022 00:00:00 GMT-0600
new Date(2022,10,8)  // -> Tue Nov 08 2022 00:00:00 GMT-0600
new Date(2022,10,9)  // -> Wed Nov 09 2022 00:00:00 GMT-0600
new Date(2022,10,10) // -> Thu Nov 10 2022 00:00:00 GMT-0600
new Date(2022,10,11) // -> Fri Nov 11 2022 00:00:00 GMT-0600
new Date(2022,10,12) // -> Sat Nov 12 2022 00:00:00 GMT-0600

I have created a pull request with the solution. #275 ([Fix 🐛] Update date format in Week component)

leonelhenriquez avatar Oct 23 '24 15:10 leonelhenriquez

Any timeline to have this fix merged?

ddematheu avatar Nov 07 '24 02:11 ddematheu

How is this still not fixed?? I'm getting complaints in my app because a date picker is important. I will create a custom patch for now... But is this project maintained, or do I have to replace this component everywhere?

vanta240i avatar Dec 17 '24 16:12 vanta240i

Hi @DreamDevourer 👋. Sorry for the late reply. Thanks @leonelhenriquez for the contribution(https://github.com/onesine/react-tailwindcss-datepicker/pull/275).

onesine avatar Jan 30 '25 10:01 onesine