unified-runtime icon indicating copy to clipboard operation
unified-runtime copied to clipboard

[CUDA][HIP] Minimize native events recorded and created by urEnqueueTimestampRecordingExp

Open hdelan opened this issue 1 year ago • 1 comments
trafficstars

Since EvStart and EvEnd are recorded directly after one another in urEnqueueTimestampRecordingExp, we can just copy EvStart to make EvEnd, instead of calling cuEventRecord for both EvStart and EvEnd, one after the other.

@steffenlarsen for discussion

hdelan avatar May 16 '24 09:05 hdelan

I now get what you meant! I'm alright with this solution. 👍

Great thanks. I'll add a DPC++ PR just to make sure no code is relying on EvEnd being after EvStart

hdelan avatar May 16 '24 10:05 hdelan

This ended up introducing some bugs and we have refactored the base event since, so closing this.

npmiller avatar Nov 05 '24 14:11 npmiller