Velocity-Bench
Velocity-Bench copied to clipboard
Hardcoded relative path in cudaSift
The cudaSift benchmark currently hardcodes a relative path to its assets. See here. This works fine as long as the benchmark is ran from repo/cudaSift/SYCL/build/ directory, but breaks down when the benchmark is built outside of the repository or when the current working directory is simply set to somewhere else.
This has forced me to do a workaround in my automation that artificially introduces an extraneous directory into the benchmark cwd that my scripts use, just so that those files can be resolved appropriately.
It would be better if the path to those files could be provider as a cli argument.
As the input files are shipped with the application, we used a relative path to where the input files are located. Will soon update the code to pass in input file location via CLI argument.
Hi @pbalcer, we have made changes to address this issue. It is currently under validation and once all goes well, we will raise a PR here.
Hi @pbalcer, PR for this issue is #74.
To specify a different dir for the input files, you will now have to pass that in as a command line parameter: ./cudasift -input_data_loc <INPUT_FILES_DIR>
The PR is now merged. I hope it addressed your issue adequately? If not, please let me know. Thanks.
@pbalcer, if this ticket addressed the issue at hand, please let me know so that this issue can be closed.
Yes, thanks!