onbjerg

Results 432 comments of onbjerg

Not in that file specifically, but transition IDs are still mentioned in function names and docs, e.g. here: https://github.com/paradigmxyz/reth/blob/600f3eac8c494dfc10b628527ff87513e2381b7f/crates/storage/provider/src/providers/database/provider.rs#L258 https://github.com/paradigmxyz/reth/blob/600f3eac8c494dfc10b628527ff87513e2381b7f/crates/storage/provider/src/providers/database/provider.rs#L123 https://github.com/paradigmxyz/reth/blob/600f3eac8c494dfc10b628527ff87513e2381b7f/crates/storage/provider/src/providers/database/provider.rs#L285

Set here https://github.com/paradigmxyz/reth/blob/2bc5e19edb49bd9a4a8c441f65958ae99cc01d02/crates/consensus/beacon/src/engine/mod.rs#L1652 which is then used as the target block for the stage instead of the highest block of the stage prior

Sorry for the delayed response, good catch, I only checked this for the middleware. Once CI passes this is good to merge

Hey, what is needed to get this over the line? @mds1 @saucepoint

I'm not sure Solidity generates sourcemaps for Yul. This is pretty hard as well - afaik ethers-solc does not support compiling Yul yet, and requires changes in both `forge run`,...

This adds a lot of complexity to `getCode`. Right now it's a pretty simple "find the artifact, extract the bytecode" which requires close to 0 knowledge of how the project...

FWIW I know of at least 2 others who have the exact same issue, also only on Mac. Unfortunately, I also know more people than that who do not have...

Interesting, I see pointing to a file gives me the correct values, however, the formatter for some reason still *retains* (sometimes it inserts them but I can't reliably reproduce) semicolons,...