aeons-end-randomizer icon indicating copy to clipboard operation
aeons-end-randomizer copied to clipboard

Published 20 hours ago • verified publisher icon on3iro

Some Past and Future fixes

Open deusabianca opened this issue 1 year ago • 9 comments

Fix Harbinger Descent's and Encased Fossil's ID, remove redundant New Age spells from PAF's cards.ts

deusabianca avatar Jul 15 '24 17:07 deusabianca

Inscrutable Artifact's id also has a space.

Torgen avatar Jul 16 '24 03:07 Torgen

@deusabianca Thanks for the fixes. Could you please also make the adjustment @Torgen suggested? Then this should be good to go :)

on3iro avatar Jul 17 '24 09:07 on3iro

Done. What I would watch for this to fix: Resonant Pearl was not appearing at all for New Age, and Harbinger Descent appearing twice for Past and Future. If it's not fixed after this I'm not sure what is causing it. image image

deusabianca avatar Jul 17 '24 13:07 deusabianca

Done. What I would watch for this to fix: Resonant Pearl was not appearing at all for New Age, and Harbinger Descent appearing twice for Past and Future. If it's not fixed after this I'm not sure what is causing it. image image

Alright, thanks for the headsup. I currently don't have time to check this out, but will soon.

on3iro avatar Jul 18 '24 19:07 on3iro

Hi, any update?

deusabianca avatar Jul 23 '24 20:07 deusabianca

Hi, any update?

Sorry not yet. Pretty busy right now.

on3iro avatar Jul 25 '24 17:07 on3iro

Finally got around to test this. Thanks @deusabianca :)

on3iro avatar Jul 27 '24 08:07 on3iro

I'll have to fix e2e-tests - don't have time for that right now. So this'll have to wait a big longer (unless you can fix them yourself @deusabianca )

on3iro avatar Jul 27 '24 09:07 on3iro

Hey @deusabianca I haven't forgotten about his, I just didn't find time, yet. Just so you know :)

on3iro avatar Aug 19 '24 12:08 on3iro

Hello, I tried to make sense of how to fix it but I have no idea honestly. Anyway I hope you're doing well.

BTW I would be more than willing to add the data for the new cards from wave 8 when that comes. But would need help for however to integrate it.

deusabianca avatar Oct 12 '24 02:10 deusabianca

Hello, I tried to make sense of how to fix it but I have no idea honestly. Anyway I hope you're doing well.

BTW I would be more than willing to add the data for the new cards from wave 8 when that comes. But would need help for however to integrate it.

hey @deusabianca , yeah - sorry that it's taking me so long to fix this. Unfortunately I don't have any time to dedicate to this right now. It will definitely be a while until I'll be able to look into this. Fixing these tests is a bit of a pain.

I think I'll remove that they are mandatory for merging for now, so I can make a release with your fixes. In the end it's just a content change anyway, so it shouldn't do any damage to the app itself.

Regarding wave 8: you are more than welcome to provide content. Thanks a lot for your effort. It might make sense to create an issue for this so we can assign you. That way other people know, that someone is already working on this. Would you please be so kind and do that? Thanks :)

on3iro avatar Oct 12 '24 15:10 on3iro

Hey @on3iro, looks like this did break the supply randomizer. This should probably be reverted for now.

And sure I can create the issue regarding wave 8.

deusabianca avatar Oct 13 '24 09:10 deusabianca

Hey @on3iro, looks like this did break the supply randomizer. This should probably be reverted for now.

And sure I can create the issue regarding wave 8.

oh, thanks for letting me know - ill revert asap

on3iro avatar Oct 13 '24 13:10 on3iro