aeons-end-randomizer
aeons-end-randomizer copied to clipboard
on3iro
[FEATURE] control initial number of mages drawn
Closes: #379
Amended expedition schema added handling code in the helper and convertExpeditionFromConfig files
Let me know if I did this PR right, either here or through discord. And let me know what you think of the changes. I think there are some separation of concerns issues with my current draft of the code, and obviously if a migration is required I haven't done that, but let me know what you think.
@Quicksav cool - thanks for the submission :) I am super busy right now, but I will try to look into this asap (i hope to find time during the upcoming weekend)
Hey @Quicksav do you intend to follow up on this? (no pressure - it's totally fine if you currently do not have time for this)
Hey man part of me really wants to get back to this, as I've really been enjoying using the app for the game and want to do a bit to make it better, but I think the reality is this is just really back burner for me and I don't think I'll be getting back to it any time soon.
On Fri, Mar 5, 2021 at 11:30 AM Theo Salzmann @.***> wrote:
Hey @Quicksav https://github.com/Quicksav do you intend to follow up on this? (no pressure - it's totally fine if you currently do not have time for this)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/on3iro/aeons-end-randomizer/pull/380#issuecomment-791601926, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKO3HJVK3S6G47476QBTXRTTCEPLDANCNFSM4R76K4AQ .
Hey man part of me really wants to get back to this, as I've really been enjoying using the app for the game and want to do a bit to make it better, but I think the reality is this is just really back burner for me and I don't think I'll be getting back to it any time soon. … On Fri, Mar 5, 2021 at 11:30 AM Theo Salzmann @.***> wrote: Hey @Quicksav https://github.com/Quicksav do you intend to follow up on this? (no pressure - it's totally fine if you currently do not have time for this) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#380 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKO3HJVK3S6G47476QBTXRTTCEPLDANCNFSM4R76K4AQ .
No worries, I can absolutely relate to that. If I have some time in the future and if you don't mind, i might do some refactoring and merge this feature :)
It's highly unlikely that I'll find the time to continue here, therefore I am closing this for now