omegaconf icon indicating copy to clipboard operation
omegaconf copied to clipboard

ensure atomic updates for ListConfig sliced assignment (#950)

Open pixelb opened this issue 3 years ago • 2 comments

  • omegaconf/listconfig.py (setitem): Operate on a copy so any changes due to validation errors etc. are discarded. Fixes issue #950

pixelb avatar Jul 14 '22 17:07 pixelb

This works but is not very efficient. It would be good to have a replace() method I think, that would avoid all the assignment checks etc. Also ideally we would shallow copy the work list in this case.

pixelb avatar Jul 14 '22 17:07 pixelb

I'll push this now, and we can optimize later

pixelb avatar Jul 28 '22 15:07 pixelb