omniauth-github icon indicating copy to clipboard operation
omniauth-github copied to clipboard

Update omniauth strategy to pass location

Open marcusguttenplan opened this issue 6 years ago • 5 comments
trafficstars

Adding additional location field from raw_info to the object that is created so that it better fits into Omniauth's Auto Hash Schema

marcusguttenplan avatar Nov 30 '18 03:11 marcusguttenplan

+1 any chance we could commit this?

ac21 avatar Apr 03 '19 20:04 ac21

Sadly this project isn't being actively maintained and I don't have write access. Feel free to use my fork if that works for you! It's a super minimal change.

marcusguttenplan avatar Apr 03 '19 20:04 marcusguttenplan

@marcusguttenplan thanks for submitting this PR. I just started reviewing old PRs here, and we can merge yours if you add a small spec to check if the location info is added correctly.

suprnova32 avatar Feb 05 '20 16:02 suprnova32

@marcusguttenplan are you still interested in getting this merged? We just need a spec added.

BobbyMcWho avatar Feb 18 '20 17:02 BobbyMcWho

I can tackle this soon, sorry for the delay!

marcusguttenplan avatar Feb 27 '20 19:02 marcusguttenplan