adrust icon indicating copy to clipboard operation
adrust copied to clipboard

Be able to announce a decision

Open omallassi opened this issue 5 years ago • 3 comments

See If / who we could announce a decision.

For instance,

  • it could be a specific command e.g. adr accounce --decision ....
  • it could be done when a decision status is updated
  • it could be done through multiple medias (Slack, Microsoft Teams, emails etc...) which may drive security (authentication at least) questions.

omallassi avatar Dec 06 '19 09:12 omallassi

@omallassi I think this is fantastic!

It would be great to see Mattermost or Zulip

A few things to consider:

  • Suppression of the announcement when an decision is created adr lf new ... as that would create a notification without substance.
  • Send a copy of the file with the announcement

rustysys-dev avatar Jun 02 '20 09:06 rustysys-dev

yes. maybe we can think about having "kind of plugins" to support different "channels". no idea how we can do this in rust but a go opportunity to learn :)

omallassi avatar Jun 03 '20 08:06 omallassi

I think it would be interesting to develop a plugin system.

Choosing the plugin could be as easy as adr announce --decision <id||name> --plugin <plugin_name>

id being an idea from #36 as decision names could be long and typing an id preferable.

Additionally, the default plugin for the user could be defined in the config as adr_default_announce_plugIn

As far as implementation goes, I'm not an expert in rust by any means so correct me if I am wrong but we could create a trait (announce_plugin or something similar) and implement it for each of the plugin structs. This would allow for a unified interface for all announce_plugins...what do you think?

rustysys-dev avatar Jun 03 '20 08:06 rustysys-dev