[Bug]: Error: Uncaught TypeError: Cannot read properties of undefined (reading 'isComic')

[YoukaiKowai]

Preflight Checklist

• [X] I have searched the issue tracker for a bug report that matches the one I want to file, without success.

OpenComic Version

1.2.0

Operating System

Windows 10 22H2 Build 19045.4780

Steps to reproduce

Open any Manga .cbz archive.

Expected Behavior

It should open normally without any issues.

Actual Behavior

Instead, it freezes like this.

Error message

It shows this error when I try to exit OpenComic.

Error: Uncaught TypeError: Cannot read properties of undefined (reading 'isComic') at linenumber 1251:10 of file C:\Users\***\AppData\Local\Programs\OpenComic\resources\app.asar\scripts\dom.js
TypeError: Cannot read properties of undefined (reading 'isComic')
    at Object.indexPathControlUpdateLastComic (C:\Users\***\AppData\Local\Programs\OpenComic\resources\app.asar\scripts\dom.js:1251:10)
    at saveReadingProgress (C:\Users\***\AppData\Local\Programs\OpenComic\resources\app.asar\scripts\reading.js:3194:6)
    at Object.saveReadingProgress (C:\Users\***\AppData\Local\Programs\OpenComic\resources\app.asar\scripts\reading.js:3167:4)
    at HTMLSpanElement.onclick (file:///C:/Users/***/AppData/Local/Programs/OpenComic/resources/app.asar/templates/index.html:1:9)

Additional Information

This doesn't happen with every manga archive, so please let me know if you need the actual files where this issue occurs.

Sample file

No response

[YoukaiKowai]

Update: The problem was solved by extracting the archive and renaming the folder. Please, delete this issue.

[ollm]

Please can you try the following master build, although you have solved the problem by extracting the cbz file, OpenComic should open cbz files without any errors.

If still happening, you can send me the cbz to this email: [email protected]

Build: https://mega.nz/file/rbZEgbRI#rGbM2her1XlWFlQf9ZbAuJZSt8NOiOo359TQOMr8w-A

[gsxgmpkt9020]

Please can you try the following master build, although you have solved the problem by extracting the cbz file, OpenComic should open cbz files without any errors.

If still happening, you can send me the cbz to this email: [email protected]

Build: https://mega.nz/file/rbZEgbRI#rGbM2her1XlWFlQf9ZbAuJZSt8NOiOo359TQOMr8w-A

I encounted this too. I will test it for you.

[YoukaiKowai]

The master build works perfectly. Thank you!

[gsxgmpkt9020]

Please can you try the following master build, although you have solved the problem by extracting the cbz file, OpenComic should open cbz files without any errors. If still happening, you can send me the cbz to this email: [email protected] Build: https://mega.nz/file/rbZEgbRI#rGbM2her1XlWFlQf9ZbAuJZSt8NOiOo359TQOMr8w-A

I encounted this too. I will test it for you.

Still errors with endless loading for a certain comic subfolder

node:fs:1665 Uncaught (in promise) Error: ENOENT: no such file or directory, stat 'D:\Komga\Queen\OrangeMaru (YD)\(C103) [OrangeMaru (YD)] OrangeMaru vol.14 (アズールレーン).cbz'
    at statSync (node:fs:1665:25)
    at t.statSync (node:electron/js2c/node_init:2:5397)
    at Object.firstCompressedFile (C:\Program Files\OpenComic\resources\app.asar\scripts\file-manager.js:2912:105)
    at headerPath (C:\Program Files\OpenComic\resources\app.asar\scripts\dom.js:1021:41)
    at Object.openComic (C:\Program Files\OpenComic\resources\app.asar\scripts\dom.js:2154:2)
    at Object.loadIndexPage (C:\Program Files\OpenComic\resources\app.asar\scripts\dom.js:737:8)
    at HTMLDivElement.onclick (index.html:1:5)
/C:/Users/ADMINI~1/AppData/Local/Temp/opencomic/epub-zip-65118b235727e7dc9ddc0f1ee5c6a9187f634df3/OPS/META-INF/com.apple.ibooks.display-options.xml:1 
        
        
       Failed to load resource: net::ERR_FILE_NOT_FOUND
C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:304 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'getBoundingClientRect')
    at disposeImages (C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:304:61)
    at resized (C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:2720:4)
    at Object.hideContent (C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:2791:3)
    at fullScreen (opencomic.js:22:10)
    at HTMLDocument.<anonymous> (opencomic.js:36:4)
C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:304 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'getBoundingClientRect')
    at disposeImages (C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:304:61)
    at resized (C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:2720:4)
C:\Program Files\OpenComic\resources\app.asar\scripts\dom.js:1311 Uncaught TypeError: Cannot read properties of undefined (reading 'isComic')
    at Object.indexPathControlUpdateLastComic (C:\Program Files\OpenComic\resources\app.asar\scripts\dom.js:1311:10)
    at saveReadingProgress (C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:3393:6)
    at saveReadingProgress (C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:3366:4)
indexPathControlUpdateLastComic @ C:\Program Files\OpenComic\resources\app.asar\scripts\dom.js:1311
saveReadingProgress @ C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:3393
saveReadingProgress @ C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:3366
C:\Program Files\OpenComic\resources\app.asar\node_modules\node-unrar-js\dist\js\unrar.js:9 Uncaught TypeError: Cannot read properties of undefined (reading 'isComic')
    at Object.indexPathControlUpdateLastComic (C:\Program Files\OpenComic\resources\app.asar\scripts\dom.js:1311:10)
    at saveReadingProgress (C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:3393:6)
    at saveReadingProgress (C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:3366:4)
indexPathControlUpdateLastComic @ C:\Program Files\OpenComic\resources\app.asar\scripts\dom.js:1311
saveReadingProgress @ C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:3393
saveReadingProgress @ C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:3366
C:\Program Files\OpenComic\resources\app.asar\scripts\dom.js:1311 Uncaught TypeError: Cannot read properties of undefined (reading 'isComic')
    at Object.indexPathControlUpdateLastComic (C:\Program Files\OpenComic\resources\app.asar\scripts\dom.js:1311:10)
    at saveReadingProgress (C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:3393:6)
    at saveReadingProgress (C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:3366:4)
indexPathControlUpdateLastComic @ C:\Program Files\OpenComic\resources\app.asar\scripts\dom.js:1311
saveReadingProgress @ C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:3393
saveReadingProgress @ C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:3366
C:\Program Files\OpenComic\resources\app.asar\node_modules\node-unrar-js\dist\js\unrar.js:9 Uncaught TypeError: Cannot read properties of undefined (reading 'isComic')
    at Object.indexPathControlUpdateLastComic (C:\Program Files\OpenComic\resources\app.asar\scripts\dom.js:1311:10)
    at saveReadingProgress (C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:3393:6)
    at saveReadingProgress (C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:3366:4)
indexPathControlUpdateLastComic @ C:\Program Files\OpenComic\resources\app.asar\scripts\dom.js:1311
saveReadingProgress @ C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:3393
saveReadingProgress @ C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:3366

I have some errors when the file [OrangeMaru (YD)] OrangeMaru vol.14 (アズールレーン).cbz is existed. After I removed the file and cache. Above errors are still displayed.

[ollm]

The error is because OpenComic was not checking if the file existed when trying to open the last read when the Open directly in continue reading instead of the file list (Folders) option was enabled, this could also happen when going forward and back, this should fix it 2948ac64e6153ac8934ca15839cefbbedd7a7a40

Build: https://mega.nz/file/3LpggAiR#2PpO6FUjIEfW7yP6QEpTQ4Te6b4boUyILffOr24fMl4

[gsxgmpkt9020]

The error is because OpenComic was not checking if the file existed when trying to open the last read when the Open directly in continue reading instead of the file list (Folders) option was enabled, this could also happen when going forward and back, this should fix it 2948ac6

Build: https://mega.nz/file/3LpggAiR#2PpO6FUjIEfW7yP6QEpTQ4Te6b4boUyILffOr24fMl4

It is fixed now

[gsxgmpkt9020]

The error is because OpenComic was not checking if the file existed when trying to open the last read when the Open directly in continue reading instead of the file list (Folders) option was enabled, this could also happen when going forward and back, this should fix it 2948ac6 Build: https://mega.nz/file/3LpggAiR#2PpO6FUjIEfW7yP6QEpTQ4Te6b4boUyILffOr24fMl4

It is fixed now

(reading 'isComic') is still buggy even in this version

-1725102127610.log

C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:304 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'getBoundingClientRect')
    at disposeImages (C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:304:61)
    at resized (C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:2720:4)
C:\Program Files\OpenComic\resources\app.asar\scripts\dom.js:1323 Uncaught TypeError: Cannot read properties of undefined (reading 'isComic')
    at Object.indexPathControlUpdateLastComic (C:\Program Files\OpenComic\resources\app.asar\scripts\dom.js:1323:10)
    at saveReadingProgress (C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:3393:6)
    at saveReadingProgress (C:\Program Files\OpenComic\resources\app.asar\scripts\reading.js:3366:4)

[dajotim937]

The error is because OpenComic was not checking if the file existed when

When you open cbz file in OpenComic, delete file using explorer and then file->open file location throw error.

[ollm]

This build should fix both bugs cc337f20a53e78320b256e89ccc31a2d27cda890

Also includes the change of copyToTmp to fileToBlob c8086ba5525ce389aba86891fa241c731babdd2c mentioned in https://github.com/ollm/OpenComic/issues/241#issuecomment-2308178469, I've done some tests and there is no noticeable difference in performance, the hard drive would have to be much slower than the main drive to appreciate it.

Build: https://mega.nz/file/eaZjlLbS#RB4lE9ZYM2nYv6oyN8JRc8-8D5-6HDMVnX-ZtnzBvbA

[gsxgmpkt9020]

This build should fix both bugs cc337f2

Also includes the change of copyToTmp to fileToBlob c8086ba mentioned in #241 (comment), I've done some tests and there is no noticeable difference in performance, the hard drive would have to be much slower than the main drive to appreciate it.

Build: https://mega.nz/file/eaZjlLbS#RB4lE9ZYM2nYv6oyN8JRc8-8D5-6HDMVnX-ZtnzBvbA

So far so good !

[ollm]

Closed as fixed and available in v1.3.0