miningcore icon indicating copy to clipboard operation
miningcore copied to clipboard

Documentation and confusion

Open binaryf opened this issue 3 years ago • 21 comments

Describe the bug

Everything runs smoothly except "eth_sendTransaction".

According to https://github.com/oliverw/miningcore/wiki/Coin-Daemon-&-Wallet-RPC#ethereum you can run go-ethereum (geth) with:

$ geth --cache 1024 --mine --http --http.port 8545 --unlock --password --allow-insecure-unlock

Mining works fine. But after a mined block, I get an error when Miningcore should reward the miners on the pool.

Miningcore says "System.Exception: eth_sendTransaction returned error: invalid sender code -32000" Geth says err="invalid sender"

I can transfere founds in the go-ethereum javasript console.

Have I forgot something here ?

To Reproduce Steps to reproduce the behavior:

  1. Setup go-ethereum according to documentation.
  2. Setup Miningcore according to documentation.
  3. Run mining on Miningcore.
  4. Find a block.
  5. No payment for miners due to error in configuration.

Expected behavior

Mining and payment should work by following instructions or manual.

Screenshots

I can provide screenshot If needed, or any other information. Maybe this is something that others also run into, and can be fixed by providing a little more information.

Platform and software

  • Ubuntu 22.04 LTS
  • Latest Miningcore.
  • Go-ethereum (geth) v1.20.1-beta (https://github.com/ethereumpow/go-ethereum/releases)

binaryf avatar Sep 15 '22 05:09 binaryf

Forgive my ignorance but isn't this question purely academic as of yesterday?

oliverw avatar Sep 15 '22 07:09 oliverw

Maybe it is a bug ?

binaryf avatar Sep 15 '22 07:09 binaryf

Maybe it is a bug ?

Its most likely a bug but what is the relevance after yesterdays merge?

oliverw avatar Sep 15 '22 07:09 oliverw

Ah! Got it! :) Have a pool 90% set up for ETHPOW fork :)

binaryf avatar Sep 15 '22 07:09 binaryf

Ah ok. Will look into it in a bit.

oliverw avatar Sep 15 '22 07:09 oliverw

Let me know if you need more info. Thanks!

binaryf avatar Sep 15 '22 07:09 binaryf

We also had an issue with miningcore when miningcore tried to pay miners more than the incoming balance in the base wallet.

It is possible that this was an issue (behaviour) beacause of a little messy dev-setup and the back and forth trying to get things working.

But it is very strange that miningcore are reporting reward: 5 when the ethereum pow block explorer says about 2 ether.

Here is the link to the dev setup: http://miningpool.no:4000/api/pools/miningpool1/blocks

UI is at http://miningpool.no/

You might want to look into this if this is related to the ethereum pow fork witch launches soon.

binaryf avatar Sep 15 '22 10:09 binaryf

So it was an uncle identified as a full block?

oliverw avatar Sep 15 '22 10:09 oliverw

I need to see the block explorer to be sure.

https://iceberg.ethwscan.com/blocks

But it is down at the moment.

binaryf avatar Sep 15 '22 10:09 binaryf

Looks like the block explorer for the testnet is permanently down.

It should be easy to reproduce. I can make a compact list of steps.

binaryf avatar Sep 16 '22 03:09 binaryf

Block reward should be 2.00 ETHW.

binaryf avatar Sep 16 '22 06:09 binaryf

Work Great here. Its actualy 2ethw +netfee so it can be higer and you have unicles that is less and orphan 0.

totom9000 avatar Sep 16 '22 08:09 totom9000

Block reward should be 2.00 ETHW.

What coin are we actually talking about?

oliverw avatar Sep 16 '22 08:09 oliverw

Ethereum POW (ETHPOW, ETHW) https://ethereumpow.org/

binaryf avatar Sep 16 '22 09:09 binaryf

Ethereum POW (ETHPOW, ETHW) https://ethereumpow.org/

So this is an issue about a coin that's not actually supported by MC? And you didn't even mention that?

oliverw avatar Sep 16 '22 09:09 oliverw

Sorry. I should have. Thought since it is basicly ethereum i did not underline it.

I thought the issue was I/O related between MC and Geth.

binaryf avatar Sep 16 '22 09:09 binaryf

Ah! Got it! :) Have a pool 90% set up for ETHPOW fork :)

What was the solution for your issue?

System.Exception: eth_sendTransaction returned error: invalid sender code -32000" Geth says err="invalid sender" I remember seeing the same error a very long time ago while testing ETH, but cannot remember what the solution was.

What was it in your case?

seperatis avatar Sep 17 '22 16:09 seperatis

Might be worth giving dev a shot. I have pushed 7973a2bf19a5acdddd57b1e88df3eebd4dd8d663 a couple hours ago.

oliverw avatar Sep 17 '22 16:09 oliverw

Great! Thank you.

binaryf avatar Sep 18 '22 05:09 binaryf

Any findings?

oliverw avatar Sep 19 '22 10:09 oliverw

New server is up. But the blockchain is in "heal mode". Will let you know.

binaryf avatar Sep 20 '22 03:09 binaryf

New server is up. But the blockchain is in "heal mode". Will let you know.

So?

oliverw avatar Sep 26 '22 09:09 oliverw

Still "State heal in progress"

binaryf avatar Sep 27 '22 05:09 binaryf

Still "State heal in progress"

It really shouldn't take that long. I'd start over with a clean slate if I was you.

oliverw avatar Sep 27 '22 08:09 oliverw

Ethw actualy takes manny manny hours to sync. We usualy dl chain add it inn manual as its multiple GB in size. And do a reindex as its faster. Ethw is same as eth. Etc dont alow you to runn wallet in prune. And dont realy help woth good nodes as it simple go slow.

totom9000 avatar Sep 27 '22 08:09 totom9000

Ethw actualy takes manny manny hours to sync. We usualy dl chain add it inn manual as its multiple GB in size. And do a reindex as its faster. Ethw is same as eth. Etc dont alow you to runn wallet in prune. And dont realy help woth good nodes as it simple go slow.

Hours? @binaryf posted his last update 7 days ago.

oliverw avatar Sep 27 '22 08:09 oliverw