Oli Scherer

Results 756 comments of Oli Scherer

> So, I think what happens here is that we don't do promotion because of the `Drop`, I'm assuming changing that, specifically for promotion in consts/statics is not gonna fly?...

> If we absolutely must accept this code then we can make const-eval do a type-driven traversal of the `x` in `&x` expressions to check whether there's any `UnsafeCell` anywhere....

I guess we each hate each other's preferred solution, and neither of us love our own preferred solution. So... @rust-lang/lang We did an accidental breaking change in #119044 The following...

I am unable to reproduce the pre-release failure with either the pinned nightly or the pinned stable. I'm guessing there was some update that wasn't tracked (`Cargo.lock` is not committed,...

we could use something like the `./miri` script: https://github.com/rust-lang/miri/blob/master/miri This should allow us to work completely locally. Maybe we can even the miri script be a wrapper around another script...

Could we ship the miri library together with the binary so priroda can just use the one from rustup instead of having a git dependency?

@bors r- I really need to figure out how to reproduce this locally