kafka icon indicating copy to clipboard operation
kafka copied to clipboard

Published 20 hours ago • verified publisher icon oleksiyk

SASL PLAIN over TLS

Open p-thorpe opened this issue 9 years ago • 7 comments

I'm interested in using the no-kafka client with IBM Message Hub. To achieve this there are some requirements to be met regarding connection and authentication as documented here: How to connect and authenticate.

There was a previous issue https://github.com/oleksiyk/kafka/issues/89 around this and you mentioned that the 3.0 branch had TLS support but you had some other Kafka 0.10 things to try first. How's that going? Did you have any plans for SASL PLAIN once TLS is in place?

p-thorpe avatar Aug 31 '16 12:08 p-thorpe

Configuration might look like this https://github.com/p-thorpe/no-kafka/commit/feb921475d4a27cf2ba2724c460d436abbb4094b? Proposes a small change to the ssl config location you have in the 3.0 branch currently.

p-thorpe avatar Sep 02 '16 11:09 p-thorpe

@oleksiyk, I've had a go at something around this. Would be great if you could review? https://github.com/p-thorpe/no-kafka/tree/sasl_ssl

I haven't created a pull request as I doubt you will want to take this all in one go. Would be happy to work with you to get the required pieces out of this and the 3.0 branches in any way you deem appropriate.

Thanks!

p-thorpe avatar Sep 13 '16 10:09 p-thorpe

I'm happy to merge this into 3.0 branch. I was going to implement protocol changes made in Kafka 0.10 but I really don't have time for this right now.

oleksiyk avatar Sep 13 '16 15:09 oleksiyk

Disappointing that you didn't take the configuration suggestion for 3.0 as it'll make this harder to add on top.

p-thorpe avatar Nov 14 '16 10:11 p-thorpe

You should have made a pull request for 3.0 branch as discussed earlier.

oleksiyk avatar Nov 14 '16 10:11 oleksiyk

No worries, I didn't want to over-complicate the delivery of SSL that others were waiting on. I'll just make changes to make it fit.

p-thorpe avatar Nov 14 '16 10:11 p-thorpe

Hello,

I'm just wondering, I see that ssl support was added in v3.0 Is SASL support included in that?

SASL is new to me, there are different implementations?

edit Ok, I've done some reading in the meantime, it looks like SASL support is quite different,
@p-thorpe it looks like you might have been working on an implementation of this? -I can't see the referenced branch on your fork though

vidhill avatar Jun 06 '17 18:06 vidhill