Oleg Taranenko
Oleg Taranenko
Hi Matt, I'm pretty interested in fixing this issue, as far as it is a show stopper for my migrating to the React 18. Let me know if you maybe...
@marwen-cherif great catch! one minor improvement... I've added question mark '?' to children, as far as it is possible to set Tooltip body via html prop ``` import { cloneElement,...
> I'm not sure we should change it, because watchTrades uses `watchTradesForSymbols` in the background partially you are right. The issue is that `binance.watchTrades` is delegated to `binance.watchTradesForSymbols` ``` async...
as a result by change options.watchTrades = 'aggTrade', it will sill work with 'trade' channel
@carlosmiei last commit avoid contract break, and 1) makes options.watchTrades working 2) allows using required channel on fly with params.name option
@kbventures AFAIK commex exchange is very close to binance, at least from business point of view. Why not inherit if from binance.ts? Did you investigate this possibility?
maybe change script to `cli`? would be more natural? ``` npm run cli ```
maybe need to reflect this in readme.md?
[Patch](https://github.com/vadimdemedes/pastel/pull/60) is created, but honestly this is a quick-n-dirty solution.
> side-note: re-creating instance and re-loading markets might be a sign of incorrect implementation of userland app. you typically have to instantiate the exchange instance & load markets once and...