okta-react icon indicating copy to clipboard operation
okta-react copied to clipboard

React-router version issues

Open sheam opened this issue 6 years ago • 2 comments

I'm submitting this issue for the package(s):

  • [ ] jwt-verifier
  • [ ] okta-angular
  • [ ] oidc-middleware
  • [ x] okta-react
  • [ ] okta-react-native
  • [ ] okta-vue

I'm submitting a:

  • [x ] Bug report
  • [ ] Feature request
  • [ ] Other (Describe below)

Current behavior

The auth prop is passed as undefined if React-Router version is less than 4.x. It is set properly if 'react-router-dom' is used.

Expected behavior

If older versions of react router are not supported that compile (webpack) would fail, or the documentation would reflect this.

Minimal reproduction of the problem with instructions

setup a react application using react-router version 3.x, and then follow the example given in the Okta quickstart guide for React.

Extra information about the use case/user story you are trying to implement

I am trying to add Okta to an existing React application, which uses an older version of React router.

Environment

  • Package Version: latest
  • Browser: chrome
  • OS: windows 10
  • Node version (node -v): 8.11.3
  • Other:

sheam avatar Jan 23 '19 19:01 sheam

Thanks for the report, we'll look into this further.

For clarity, you are currently not blocked and just helping us correct the information for others, correct?

swiftone avatar Jan 23 '19 19:01 swiftone

Well, we are blocked. But if the only solution is to upgrade to react-router-dom, then that is our problem. So yes, this would be to help correct the information.

sheam avatar Jan 23 '19 19:01 sheam