openid-connect-generic icon indicating copy to clipboard operation
openid-connect-generic copied to clipboard

$token_response in create_new_user does not exist

Open tripflex opened this issue 6 years ago • 0 comments

I only noticed this while browsing the code in PHPStorm and noticed the lint error so figured I would mention it here

https://github.com/daggerhart/openid-connect-generic/blob/f3829b48e28eeb7e8548749a90d489d886f0af45/includes/openid-connect-generic-client-wrapper.php#L664

$token_response is not set anywhere in the create_new_user method, so if values are missing, that code block will never actually be ran.

Maybe $token_response was meant to be passing to create_new_user method but never was? https://github.com/daggerhart/openid-connect-generic/blob/f3829b48e28eeb7e8548749a90d489d886f0af45/includes/openid-connect-generic-client-wrapper.php#L361

tripflex avatar Jul 18 '19 19:07 tripflex