react-hooks-cheatsheet icon indicating copy to clipboard operation
react-hooks-cheatsheet copied to clipboard

Can't scroll down in some doc pages

Open bovas85 opened this issue 6 years ago • 14 comments

On mobile and desktop mode on chrome latest on android 9 I can't scroll down the page where other examples are. Link https://react-hooks-cheatsheet.surge.sh/useeffect

Seems an issue with fixed heights or overflow being hidden.

I can send a PR later today unless you can fix earlier

bovas85 avatar May 24 '19 07:05 bovas85

@bovas85 thanks for opening the issue. I can have a look later today, however, it'd be great if you sent a PR as well 😊

ohansemmanuel avatar May 27 '19 05:05 ohansemmanuel

I'll try to once I get a moment. Crazy weekend (it was holiday on Monday here in UK)

bovas85 avatar May 28 '19 06:05 bovas85

Totally get it! 😆

ohansemmanuel avatar May 28 '19 15:05 ohansemmanuel

I see the same issue.

aspiers avatar Jul 10 '19 01:07 aspiers

I'll look into this.

ohansemmanuel avatar Jul 14 '19 09:07 ohansemmanuel

I have the same issue. If I open the page on portrait mode (snap the browser window to half a screen) it does not scroll at all. If a page is opened in landscape (fullscreen) and then resized to portrait it works fine.

intisavariable avatar May 19 '20 09:05 intisavariable

I cloned the repo, will look into trying to fix it if I can figure out what's the problem, any help/suggestions welcome

intisavariable avatar May 19 '20 09:05 intisavariable

Update: The bug only occurs after opening the hamburger menu and clicking the link. It does not persist through the refresh.

intisavariable avatar May 19 '20 09:05 intisavariable

Thanks @intisavariable I've had my hands full. Any luck with this? I'll perhaps take a second look today too.

ohansemmanuel avatar Jun 04 '20 07:06 ohansemmanuel

the issue is clear but I have no idea how to fix it due to the abstractions on top of the docs.

the HTML tag gets a class of with-overlay which is not removed upon route change

bovas85 avatar Jun 04 '20 08:06 bovas85

@bovas85 do you get the same issue with this link: https://react-hooks-cheatsheet.com/useeffect i.e can't scroll down

ohansemmanuel avatar Jun 04 '20 13:06 ohansemmanuel

Yes, I can't open nested menu items as well, but the issue appears once you go to a menu and to another page. The overflow: hidden of the html tag is not removed

bovas85 avatar Jun 04 '20 13:06 bovas85

I'm gonna perhaps rewrite to use another documentation library. Shouldn't be as much work since the core by itself is just MDX and basic React components

ohansemmanuel avatar Jun 05 '20 06:06 ohansemmanuel

Adding an overflow-y: auto to #root fixes the issue, seems like a rewriting would be more work

knownasilya avatar Sep 09 '21 14:09 knownasilya