libdnet icon indicating copy to clipboard operation
libdnet copied to clipboard

Published 20 hours ago • verified publisher icon ofalk

Update icmp.h

Open Lomasterrrr opened this issue 1 year ago • 1 comments

here too the fields are incorrectly sized, you can understand even by the htons function in the icmp_pack_hdr_mask macro.

Lomasterrrr avatar Jun 11 '24 18:06 Lomasterrrr

Likewise to #101 - I think it's uint32 because of ICMPv6, but maybe I'm missing something.

ofalk avatar Jun 18 '24 09:06 ofalk

Likewise to #101 - I think it's uint32 because of ICMPv6, but maybe I'm missing something.

Yes, likewise, 16bit are enough.

ofalk avatar Feb 13 '25 16:02 ofalk

In ICMPv6 there is no query mask. And in icmp4 its id and seq fields are 16 bits. In RFC 590 it is not written directly, but by the ASCII art of the header, you can see that the size of these fields is 16 bits.

To prove it I can attach screenshots from wireshark, where you can see that this message has everything as I say,

https://i.imgur.com/NVYUKJi.png https://i.imgur.com/5VUcXBS.png

Lomasterrrr avatar Feb 13 '25 18:02 Lomasterrrr