odoo icon indicating copy to clipboard operation
odoo copied to clipboard

[IMP] core: introduce condition operator 'any*' to simplify joins in queries

Open kmagusiak opened this issue 6 months ago • 2 comments

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

kmagusiak avatar May 19 '25 13:05 kmagusiak

Pull request status dashboard

robodoo avatar May 19 '25 13:05 robodoo

I just fixed up some commit messages.

rco-odoo avatar Jun 18 '25 09:06 rco-odoo

@odoo/rd-security could you check if this is ok in terms of security?

kmagusiak avatar Jul 02 '25 12:07 kmagusiak

A mere * suffix seems a bit too glib and easy to miss for disabling ACL checks, and very much not in keeping with the usual lingo for that. Even more so for something which seems mostly targeted at ORM-internal optimisations but will inevitably leak out in short order.

Indeed, we thought of other names like "any_sudo" (the operator is not really a sudo, it bypasses only security at the level of the domain, but not sub-domains). Any suggestion for a better name?

kmagusiak avatar Jul 04 '25 10:07 kmagusiak

Indeed, we thought of other names like "any_sudo" (the operator is not really a sudo, it bypasses only security at the level of the domain, but not sub-domains). Any suggestion for a better name?

Not really, any_sudo was also what I was thinking about. And while it's not as bad as an an actual sudo due to not being recursive / infective, that is its effect on security checks.

xmo-odoo avatar Jul 04 '25 11:07 xmo-odoo

Merge method set to rebase and fast-forward.

robodoo avatar Jul 09 '25 12:07 robodoo