Odin icon indicating copy to clipboard operation
Odin copied to clipboard

core:math/noise noise.noise_2d(seed, {0,0}) is discontinuous and the same value regardless of seed.

Open thePHTest opened this issue 2 years ago • 2 comments

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

  • Operating System & Odin Version: Odin: dev-2023-08-nightly:9453b238 OS: Windows 11 Professional (version: 22H2), build 22621.2283 CPU: AMD Ryzen Threadripper PRO 3955WX 16-Cores RAM: 65388 MiB

Expected Behavior

New values for different seeds when using 0,0 for the coordinate. No discontinuity at 0.0 .

Current Behavior

The result of noise.noise_2d(seed, {0,0}) is always 0.00000000 or -0.00000000 regardless of the seed and leads to a discontinuity.

I haven't tested any of the other noise functions to see if they have the same issue

thePHTest avatar Oct 13 '23 21:10 thePHTest

Good catch. Makes me wonder if that holds true for the C noise library it's based on, or an artefact of @NoahR02's port that we missed at the time.

Kelimion avatar Oct 13 '23 22:10 Kelimion

Well there is this open issue for it so looks like it's in the original C noise library too: https://github.com/KdotJPG/OpenSimplex2/issues/21

thePHTest avatar Oct 13 '23 23:10 thePHTest